paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use stream_id for by_stream__uri().

Browse Source 
The stream_list test that was fixed here was sort of
broken.  It accomplished the main goal of verifying
what gets rendered, but now the data setup part is
more like the actual app code (and simpler, too).
This commit is contained in:
Steve Howell
2018-12-14 18:18:24 +00:00
committed by Tim Abbott
parent aea074e744
commit 012bb7b6c7
6 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/click_handlers.js
View File

@@ -195,9 +195,9 @@ exports.initialize = function () {
e.preventDefault();
// Note that we may have an href here, but we trust the stream id more,
// so we re-encode the hash.
var stream = stream_data.get_sub_by_id($(this).attr('data-stream-id'));
if (stream) {
hashchange.go_to_location(hash_util.by_stream_uri(stream.name));
var stream_id = $(this).attr('data-stream-id');
if (stream_id) {
hashchange.go_to_location(hash_util.by_stream_uri(stream_id));
return;
}
window.location.href = $(this).attr('href');