paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

blueslip: Add measure_time wrapper.

Browse Source 
Now when we want to measure how long a block
of code takes to execute, we just wrap it with
`blueslip.measure_time`, instead of the awkward
idiom from my original commit of getting a callback
function.

My rationale for the original scheme was that I
wanted to minimize diffs and avoid changing
`const` to `let` in a few cases, but I believe
now that the function wrapper is nicer.

In a few cases I just removed the blueslip timing
code, since I was able to confirm on czo that
the times were pretty minimal.
This commit is contained in:
Steve Howell
2021-01-31 12:57:52 +00:00
committed by Tim Abbott
parent 4bcf7131c1
commit 016038dcd1
9 changed files with 33 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/blueslip.js
View File

@@ -251,14 +251,12 @@ exports.error = function blueslip_error(msg, more_info, stack) {
exports.timings = new Map();
exports.start_timing = function (label) {
exports.measure_time = function (label, f) {
const t1 = performance.now();
return function () {
const t2 = performance.now();
const elapsed = t2 - t1;
exports.timings.set(label, elapsed);
};
f();
const t2 = performance.now();
const elapsed = t2 - t1;
exports.timings.set(label, elapsed);
};
// Produces an easy-to-read preview on an HTML element. Currently