paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

blueslip: Add measure_time wrapper.

Browse Source 
Now when we want to measure how long a block
of code takes to execute, we just wrap it with
`blueslip.measure_time`, instead of the awkward
idiom from my original commit of getting a callback
function.

My rationale for the original scheme was that I
wanted to minimize diffs and avoid changing
`const` to `let` in a few cases, but I believe
now that the function wrapper is nicer.

In a few cases I just removed the blueslip timing
code, since I was able to confirm on czo that
the times were pretty minimal.
This commit is contained in:
Steve Howell
2021-01-31 12:57:52 +00:00
committed by Tim Abbott
parent 4bcf7131c1
commit 016038dcd1
9 changed files with 33 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
static/js/subs.js
View File

@@ -400,15 +400,16 @@ function get_stream_id_buckets(stream_ids, query) {
}
exports.populate_stream_settings_left_panel = function () {
const finish = blueslip.start_timing("render left panel");
const sub_rows = stream_data.get_updated_unsorted_subs();
let html;
blueslip.measure_time("render left panel", () => {
const sub_rows = stream_data.get_updated_unsorted_subs();
const template_data = {
subscriptions: sub_rows,
};
const template_data = {
subscriptions: sub_rows,
};
const html = render_subscriptions(template_data);
finish();
html = render_subscriptions(template_data);
});
ui.get_content_element($("#subscriptions_table .streams-list")).html(html);
};