paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: Replace set_up_scrollbar with data-simplebar attribute.

Browse Source 
With perfectScrollbar, we needed to call a function from JavaScript to
enable a scrollbar on a new element, but simplebar has a much simpler
default API one can do by using data-simplebar attributes in the HTML.

So we can delete all the scrollbar creation/deletion code.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-05-17 14:11:33 -07:00
committed by Tim Abbott
parent 119948022f
commit 01613e71fb
32 changed files with 22 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/attachments_ui.js
View File

@@ -131,12 +131,9 @@ exports.update_attachments = function (event) {
exports.set_up_attachments = function () {
// The settings page must be rendered before this function gets called.
var uploaded_files_table = $("#uploaded_files_table").expectOne();
var status = $('#delete-upload-status');
loading.make_indicator($('#attachments_loading_indicator'), {text: 'Loading...'});
ui.set_up_scrollbar(uploaded_files_table.closest(".progressive-table-wrapper"));
$('#uploaded_files_table').on('click', '.remove-attachment', function (e) {
delete_attachments($(e.target).closest(".uploaded_file_row").attr('data-attachment-id'));
});