paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui: Replace set_up_scrollbar with data-simplebar attribute.

Browse Source 
With perfectScrollbar, we needed to call a function from JavaScript to
enable a scrollbar on a new element, but simplebar has a much simpler
default API one can do by using data-simplebar attributes in the HTML.

So we can delete all the scrollbar creation/deletion code.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-05-17 14:11:33 -07:00
committed by Tim Abbott
parent 119948022f
commit 01613e71fb
32 changed files with 22 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/emoji_picker.js
View File

@@ -175,8 +175,6 @@ exports.hide_emoji_popover = function () {
$('.has_popover').removeClass('has_popover has_emoji_popover');
if (exports.reactions_popped()) {
var orig_title = current_message_emoji_popover_elem.data("original-title");
ui.destroy_scrollbar($(".emoji-popover-emoji-map"));
ui.destroy_scrollbar($(".emoji-search-results-container"));
current_message_emoji_popover_elem.popover("destroy");
current_message_emoji_popover_elem.prop("title", orig_title);
current_message_emoji_popover_elem.removeClass("reaction_button_visible");
@@ -602,8 +600,6 @@ exports.render_emoji_popover = function (elt, id) {
var popover = elt.data('popover').$tip;
popover.find('.emoji-popover-filter').focus();
ui.set_up_scrollbar(popover.find(".emoji-popover-emoji-map"));
ui.set_up_scrollbar(popover.find(".emoji-search-results-container"));
current_message_emoji_popover_elem = elt;
emoji_catalog_last_coordinates = {