paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhooks/basecamp: Fix typo in todo_due_on_changed event name.

Browse Source 
The event name seems to have been incorrectly called `todo_due_date_changed`
instead of `todo_due_on_changed`. The API docs for webhooks don't mention
the correct event name, but the TODO json payload[1] seems to contain the
`due_on` field, aside from the fixture actually referring to
`todo_due_on_changed` event type.

[1]: https://github.com/basecamp/bc3-api/blob/master/sections/todos.md
This commit is contained in:
Puneeth Chaganti
2020-04-17 16:01:18 +05:30
committed by Tim Abbott
parent 84e411c543
commit 01efb351d5
3 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

0
zerver/webhooks/basecamp/fixtures/todo_due_date_changed.json → zerver/webhooks/basecamp/fixtures/todo_due_on_changed.json
View File

2
zerver/webhooks/basecamp/support_event.py
View File

@@ -39,7 +39,7 @@ TODOS_SUPPORT_EVENTS = [
'todo_assignment_changed', 'todo_assignment_changed',
'todo_completed', 'todo_completed',
'todo_created', 'todo_created',
'todo_due_date_changed', 'todo_due_on_changed',
] ]
SUPPORT_EVENTS = DOC_SUPPORT_EVENTS + QUESTION_SUPPORT_EVENTS + MESSAGE_SUPPORT_EVENTS + TODOS_SUPPORT_EVENTS SUPPORT_EVENTS = DOC_SUPPORT_EVENTS + QUESTION_SUPPORT_EVENTS + MESSAGE_SUPPORT_EVENTS + TODOS_SUPPORT_EVENTS

4
zerver/webhooks/basecamp/tests.py
View File

@@ -123,6 +123,10 @@ class BasecampHookTests(WebhookTestCase):
expected_message = "Tomasz created the todo task [New task](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624)." expected_message = "Tomasz created the todo task [New task](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624)."
self._send_and_test_message('todo_created', expected_message) self._send_and_test_message('todo_created', expected_message)
def test_basecamp_makes_todo_due_on_changed(self) -> None:
expected_message = "Tomasz changed due_on of the todo task [New task](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624)."
self._send_and_test_message('todo_due_on_changed', expected_message)
def test_basecamp_makes_comment_created(self) -> None: def test_basecamp_makes_comment_created(self) -> None:
expected_message = "Tomasz created the [comment](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624#__recording_427058780) of the task [New task](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624)." expected_message = "Tomasz created the [comment](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624#__recording_427058780) of the task [New task](https://3.basecamp.com/3688623/buckets/2957043/todos/427055624)."
self._send_and_test_message('comment_created', expected_message) self._send_and_test_message('comment_created', expected_message)