paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Convert self-referential vars to const.

Browse Source 
ESLint won’t convert these automatically because it can’t rule out a
behavior difference arising from an access to a self-referential var
before it’s initialized:

> var x = (f => f())(() => x);
undefined
> let y = (f => f())(() => y);
Thrown:
ReferenceError: Cannot access 'y' before initialization
    at repl:1:26
    at repl:1:15

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-10-25 15:26:37 -07:00
committed by Tim Abbott
parent 7ae84d5ce1
commit 02004c9b0f
7 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/zjsunit/zjquery.js
View File

@@ -140,7 +140,7 @@ exports.make_new_elem = function (selector, opts) {
var classes = new Dict(); var classes = new Dict();
var event_store = exports.make_event_store(selector); var event_store = exports.make_event_store(selector);
var self = { const self = {
addClass: function (class_name) { addClass: function (class_name) {
classes.set(class_name, true); classes.set(class_name, true);
return self; return self;

2
static/js/feedback_widget.js
View File

@@ -26,7 +26,7 @@ var meta = {
opened: false, opened: false,
}; };
var animate = { const animate = {
maybe_close: function () { maybe_close: function () {
if (!meta.opened) { if (!meta.opened) {
return; return;

2
static/js/input_pill.js
View File

@@ -44,7 +44,7 @@ exports.create = function (opts) {
// a dictionary of internal functions. Some of these are exposed as well, // a dictionary of internal functions. Some of these are exposed as well,
// and nothing in here should be assumed to be private (due to the passing) // and nothing in here should be assumed to be private (due to the passing)
// of the `this` arg in the `Function.prototype.bind` use in the prototype. // of the `this` arg in the `Function.prototype.bind` use in the prototype.
var funcs = { const funcs = {
// return the value of the contenteditable input form. // return the value of the contenteditable input form.
value: function (input_elem) { value: function (input_elem) {
return input_elem.innerText.trim(); return input_elem.innerText.trim();

2
static/js/lightbox_canvas.js
View File

@@ -29,7 +29,7 @@ window.onload = function () {
}); });
}; };
var funcs = { const funcs = {
setZoom: function (meta, zoom) { setZoom: function (meta, zoom) {
// condition to handle zooming event by zoom hotkeys // condition to handle zooming event by zoom hotkeys
if (zoom === '+') { if (zoom === '+') {

2
static/js/list_render.js
View File

@@ -56,7 +56,7 @@ exports.create = function ($container, list, opts) {
opts.filter = {}; opts.filter = {};
} }
var prototype = { const prototype = {
// Reads the provided list (in the scope directly above) // Reads the provided list (in the scope directly above)
// and renders the next block of messages automatically // and renders the next block of messages automatically
// into the specified contianer. // into the specified contianer.

2
static/js/localstorage.js
View File

@@ -1,4 +1,4 @@
var ls = { const ls = {
// parse JSON without throwing an error. // parse JSON without throwing an error.
parseJSON: function (str) { parseJSON: function (str) {
try { try {

2
static/js/message_edit.js
View File

@@ -375,7 +375,7 @@ function edit_message(row, raw_content) {
// Do this right away, rather than waiting for the timer to do its first update, // Do this right away, rather than waiting for the timer to do its first update,
// since otherwise there is a noticeable lag // since otherwise there is a noticeable lag
message_edit_countdown_timer.text(timer_text(seconds_left)); message_edit_countdown_timer.text(timer_text(seconds_left));
var countdown_timer = setInterval(function () { const countdown_timer = setInterval(function () {
seconds_left -= 1; seconds_left -= 1;
if (seconds_left <= 0) { if (seconds_left <= 0) {
clearInterval(countdown_timer); clearInterval(countdown_timer);