paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

popovers: Encode brackets in URI to avoid conflict with markdown links.

Browse Source 
This fixes an issue where one could end up with a `(` in the markdown
syntax for a link after copy-pasting this, which doesn't work in
markdown.

Fixes #12579.
This commit is contained in:
Thomas Ip
2019-06-15 12:31:57 +08:00
committed by Tim Abbott
parent b6ce366d61
commit 0253ef12c6
3 changed files with 75 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/popovers.js
View File

@@ -431,6 +431,10 @@ exports.toggle_actions_popover = function (element, id) {
editability === message_edit.editability_types.TOPIC_ONLY;
var should_display_quote_and_reply = message.content !== '<p>(deleted)</p>';
var conversation_time_uri = hash_util.by_conversation_and_time_uri(message)
.replace(/\(/g, '%28')
.replace(/\)/g, '%29');
var should_display_delete_option = message_edit.get_deletability(message);
var args = {
message_id: message.id,
@@ -445,7 +449,7 @@ exports.toggle_actions_popover = function (element, id) {
should_display_uncollapse: should_display_uncollapse,
should_display_add_reaction_option: message.sent_by_me,
should_display_edit_history_option: should_display_edit_history_option,
conversation_time_uri: hash_util.by_conversation_and_time_uri(message),
conversation_time_uri: conversation_time_uri,
narrowed: narrow_state.active(),
should_display_delete_option: should_display_delete_option,
should_display_reminder_option: feature_flags.reminders_in_message_action_menu,