mirror of
https://github.com/zulip/zulip.git
synced 2025-11-07 07:23:22 +00:00
Fix some of our get_updates tests.
(imported from commit 250411476c6fc71cff868b16a2ab766d81c4b6b3)
This commit is contained in:
@@ -360,6 +360,9 @@ class DummyHandler(object):
|
|||||||
def async_callback(self, _):
|
def async_callback(self, _):
|
||||||
return self.callback
|
return self.callback
|
||||||
|
|
||||||
|
def finish(self, _):
|
||||||
|
return
|
||||||
|
|
||||||
class POSTRequestMock(object):
|
class POSTRequestMock(object):
|
||||||
method = "POST"
|
method = "POST"
|
||||||
|
|
||||||
@@ -385,7 +388,7 @@ class GetUpdatesTest(AuthedTestCase):
|
|||||||
self.assertTrue(zephyr in correct_zephyrs)
|
self.assertTrue(zephyr in correct_zephyrs)
|
||||||
self.assertTrue(zephyr.id > 1)
|
self.assertTrue(zephyr.id > 1)
|
||||||
|
|
||||||
request = POSTRequestMock({"last_received": 1}, user, callback)
|
request = POSTRequestMock({"last": str(1), "first": str(1)}, user, callback)
|
||||||
# get_updates returns None, which raises an exception in the
|
# get_updates returns None, which raises an exception in the
|
||||||
# @asynchronous decorator, which raises a TornadoAsyncException. So this
|
# @asynchronous decorator, which raises a TornadoAsyncException. So this
|
||||||
# is expected, but should probably change.
|
# is expected, but should probably change.
|
||||||
@@ -406,7 +409,7 @@ class GetUpdatesTest(AuthedTestCase):
|
|||||||
# and assert in the parent.
|
# and assert in the parent.
|
||||||
zephyrs = data
|
zephyrs = data
|
||||||
|
|
||||||
request = POSTRequestMock({"last_received": last_received}, user, callback)
|
request = POSTRequestMock({"last": str(last_received), "first": "1"}, user, callback)
|
||||||
self.assertRaises(TornadoAsyncException, get_updates, request)
|
self.assertRaises(TornadoAsyncException, get_updates, request)
|
||||||
self.assertEquals(len(zephyrs), 0)
|
self.assertEquals(len(zephyrs), 0)
|
||||||
|
|
||||||
@@ -425,4 +428,4 @@ class GetUpdatesTest(AuthedTestCase):
|
|||||||
self.assertTrue(zephyr.id > 1)
|
self.assertTrue(zephyr.id > 1)
|
||||||
|
|
||||||
request = POSTRequestMock({}, user, callback)
|
request = POSTRequestMock({}, user, callback)
|
||||||
self.assert_json_error(get_updates(request), "Missing last_received argument")
|
self.assert_json_error(get_updates(request), "Missing message range")
|
||||||
|
|||||||
Reference in New Issue
Block a user