paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

attachments: Use data-attachment-id to refer to attachments.

Browse Source 
This may fix an issue with the delete button not actually sending the
right data to the server; I'm not sure.  Extracted from a patch by
Aastha Gupta.
This commit is contained in:
Tim Abbott
2018-05-04 15:40:28 -07:00
parent 956bd74905
commit 02ad498aa2
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/attachments_ui.js
View File

@@ -87,7 +87,7 @@ function render_attachments_ui(attachments) {
$('#uploaded_files_table').on('click', '.remove-attachment', function (e) { $('#uploaded_files_table').on('click', '.remove-attachment', function (e) {
var row = $(e.target).closest(".uploaded_file_row"); var row = $(e.target).closest(".uploaded_file_row");
row.remove(); row.remove();
delete_attachments($(this).data('attachment')); delete_attachments($(this).attr('data-attachment-id'));
}); });
} }

2
static/templates/uploaded_files_list.handlebars
View File

@@ -1,5 +1,5 @@
{{#with attachment}} {{#with attachment}}
<tr class="uploaded_file_row" id="{{name}}"> <tr class="uploaded_file_row" id="{{name}}" data-attachment-id="{{id}}">
<td> <td>
<a type="submit" href="/user_uploads/{{path_id}}" target="_blank" title="{{t 'View file' }}"> <a type="submit" href="/user_uploads/{{path_id}}" target="_blank" title="{{t 'View file' }}">
{{ name }} {{ name }}