paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 06:28:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

tooling: Remove static/node_modules symlink.

Browse Source 
It appears not to have been useful and makes it marginally harder to
reason about how module resolution works.  Paths to static content in
node_modules should be resolved through Webpack instead.

(This node_modules symlink was originally created in the pre-webpack world
where all of our static asset paths were based in static/.)

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-06-27 14:42:16 -07:00
committed by Tim Abbott
parent 297c79eaa9
commit 02d19d48fc
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/settings_account.js
View File

@@ -312,7 +312,7 @@ exports.set_up = function () {
if (page_params.development_environment) { if (page_params.development_environment) {
// Usually the Django templates handle this path stuff // Usually the Django templates handle this path stuff
// for us, but in this case we need to hardcode it. // for us, but in this case we need to hardcode it.
zxcvbn_path = '/static/node_modules/zxcvbn/dist/zxcvbn.js'; zxcvbn_path = '/webpack/zxcvbn.js';
} }
$.getScript(zxcvbn_path, function () { $.getScript(zxcvbn_path, function () {
$('#pw_strength .bar').removeClass("fade"); $('#pw_strength .bar').removeClass("fade");

1
static/node_modules
View File

@@ -1 +0,0 @@
../node_modules/

4
zproject/settings.py
View File

@@ -934,7 +934,7 @@ JS_SPECS = {
# for bundling KaTeX. # for bundling KaTeX.
'katex': { 'katex': {
'source_filenames': [ 'source_filenames': [
'node_modules/katex/dist/katex.js', '../node_modules/katex/dist/katex.js',
], ],
'output_filename': 'min/katex.js', 'output_filename': 'min/katex.js',
}, },
@@ -943,7 +943,7 @@ JS_SPECS = {
# good way to look up the path to the file). # good way to look up the path to the file).
'zxcvbn': { 'zxcvbn': {
'source_filenames': [ 'source_filenames': [
'node_modules/zxcvbn/dist/zxcvbn.js', '../node_modules/zxcvbn/dist/zxcvbn.js',
], ],
'output_filename': 'min/zxcvbn.js' 'output_filename': 'min/zxcvbn.js'
}, },