paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

linkifier: Update edit_linkifier command to use url_template.

Browse Source 
This is mainly updating the variable names and relevant docstrings
without actual change to the behavior of the command.

Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li
2022-10-04 16:30:08 -04:00
committed by Tim Abbott
parent 268f858f39
commit 032e6f8cb4
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
zerver/management/commands/edit_linkifiers.py
View File

@@ -19,7 +19,7 @@ NOTE: Regexes must be simple enough that they can be easily translated to JavaSc
* Inline-regex flags will be stripped, and where possible translated to RegExp-wide flags * Inline-regex flags will be stripped, and where possible translated to RegExp-wide flags
Example: ./manage.py edit_linkifiers --realm=zulip --op=add '#(?P<id>[0-9]{2,8})' \ Example: ./manage.py edit_linkifiers --realm=zulip --op=add '#(?P<id>[0-9]{2,8})' \
'https://support.example.com/ticket/%(id)s' 'https://support.example.com/ticket/{id}'
Example: ./manage.py edit_linkifiers --realm=zulip --op=remove '#(?P<id>[0-9]{2,8})' Example: ./manage.py edit_linkifiers --realm=zulip --op=remove '#(?P<id>[0-9]{2,8})'
Example: ./manage.py edit_linkifiers --realm=zulip --op=show Example: ./manage.py edit_linkifiers --realm=zulip --op=show
""" """
@@ -32,10 +32,10 @@ Example: ./manage.py edit_linkifiers --realm=zulip --op=show
"pattern", metavar="<pattern>", nargs="?", help="regular expression to match" "pattern", metavar="<pattern>", nargs="?", help="regular expression to match"
) )
parser.add_argument( parser.add_argument(
"url_format_string", "url_template",
metavar="<URL pattern>", metavar="<URL template>",
nargs="?", nargs="?",
help="format string to substitute", help="URL template to expand",
) )
self.add_realm_args(parser, required=True) self.add_realm_args(parser, required=True)
@@ -52,11 +52,11 @@ Example: ./manage.py edit_linkifiers --realm=zulip --op=show
raise CommandError raise CommandError
if options["op"] == "add": if options["op"] == "add":
url_format_string = options["url_format_string"] url_template = options["url_template"]
if not url_format_string: if not url_template:
self.print_help("./manage.py", "edit_linkifiers") self.print_help("./manage.py", "edit_linkifiers")
raise CommandError raise CommandError
do_add_linkifier(realm, pattern, url_format_string, acting_user=None) do_add_linkifier(realm, pattern, url_template, acting_user=None)
sys.exit(0) sys.exit(0)
elif options["op"] == "remove": elif options["op"] == "remove":
do_remove_linkifier(realm, pattern=pattern, acting_user=None) do_remove_linkifier(realm, pattern=pattern, acting_user=None)