paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

upload: Rename uploadStarted to drop to match original convention.

Browse Source 
We used uploadStarted for drop callback which is kind of confusing
for new contributors as there is a big difference between uploadStarted
and drop like uploadStarted is called for each file in an upload whereas
the drop is called once when the file(s) are uploaded.
This commit is contained in:
Shubham Dhama
2018-04-14 13:41:18 +05:30
committed by Tim Abbott
parent 0d0f971ae1
commit 03f95ba993
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/upload.js
View File

@@ -66,7 +66,7 @@ exports.options = function (config) {
}
};
var uploadStarted = function () {
var drop = function () {
send_button.attr("disabled", "");
send_status.addClass("alert-info").show();
send_status_close.one('click', function () {
@@ -169,7 +169,7 @@ exports.options = function (config) {
csrfmiddlewaretoken: csrf_token,
},
raw_droppable: ['text/uri-list', 'text/plain'],
drop: uploadStarted,
drop: drop,
progressUpdated: progressUpdated,
error: uploadError,
uploadFinished: uploadFinished,
@@ -189,7 +189,7 @@ exports.options = function (config) {
if (window.bridge) {
var opts = exports.options({ mode: "compose" });
exports.uploadStarted = opts.drop;
exports.drop = opts.drop;
exports.progressUpdated = opts.progressUpdated;
exports.uploadError = opts.error;
exports.uploadFinished = opts.uploadFinished;