paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

reactions: Use parameter destructuring in update_existing_reaction.

Browse Source 
This is a pure code refactor for readability.
This commit is contained in:
YashRE42
2021-12-13 19:37:10 +05:30
committed by Tim Abbott
parent 0991ed4526
commit 0438ed5777
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
static/js/reactions.js
View File

@@ -279,16 +279,18 @@ export function add_reaction(event) {
} }
} }
view.update_existing_reaction = function (opts) { view.update_existing_reaction = function ({
message_id,
emoji_name,
user_list,
user_id,
reaction_type,
emoji_code,
}) {
// Our caller ensures that this message already has a reaction // Our caller ensures that this message already has a reaction
// for this emoji and sets up our user_list. This function // for this emoji and sets up our user_list. This function
// simply updates the DOM. // simply updates the DOM.
const local_id = get_local_reaction_id({reaction_type, emoji_code});
const message_id = opts.message_id;
const emoji_name = opts.emoji_name;
const user_list = opts.user_list;
const user_id = opts.user_id;
const local_id = get_local_reaction_id(opts);
const reaction = find_reaction(message_id, local_id); const reaction = find_reaction(message_id, local_id);
set_reaction_count(reaction, user_list.length); set_reaction_count(reaction, user_list.length);