From 04fb86fff71ef9921f8013fdbbaa2b3e100bce7a Mon Sep 17 00:00:00 2001 From: Rishi Gupta Date: Sat, 29 Apr 2017 23:51:32 -0700 Subject: [PATCH] confirmation: Remove newline replacement from email subjects. I think it's fine to trust that we won't mess this up. I assume this is here because it was copied from similar code in Django (e.g. see our code from the password_reset flow), rather than because it was a problem in our subject templates. --- confirmation/models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/confirmation/models.py b/confirmation/models.py index e7954a9783..9ea3d113f8 100644 --- a/confirmation/models.py +++ b/confirmation/models.py @@ -108,7 +108,7 @@ class ConfirmationManager(models.Manager): if additional_context is not None: context.update(additional_context) - subject = loader.get_template(template_prefix + '.subject').render(context).strip().replace(u'\n', u' ') # no newlines, please + subject = loader.get_template(template_prefix + '.subject').render(context).strip() body = loader.get_template(template_prefix + '.txt').render(context) try: html_content = loader.get_template(template_prefix + '.html').render(context)