paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

pointer: Move scroll suppression to message_scroll.js.

Browse Source 
This is clearly a better home for it, since message_scroll.js is the
only place that reads it, and also lets us provide a clearer name for
the functionality.
This commit is contained in:
Tim Abbott
2020-06-17 23:29:08 -07:00
committed by Tim Abbott
parent 94e6cb9abd
commit 052dbb0716
4 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/message_scroll.js
View File

@@ -1,5 +1,13 @@
let actively_scrolling = false;
// Tracks whether the next scroll that will complete is initiated by
// code, not the user, and thus should avoid moving the selected
// message.
let update_selection_on_next_scroll = true;
exports.suppress_selection_update_on_next_scroll = function () {
update_selection_on_next_scroll = false;
};
let loading_older_messages_indicator_showing = false;
let loading_newer_messages_indicator_showing = false;
exports.show_loading_older = function () {
@@ -111,10 +119,10 @@ exports.scroll_finished = function () {
return;
}
if (!pointer.suppress_scroll_pointer_update) {
if (update_selection_on_next_scroll) {
message_viewport.keep_pointer_in_view();
} else {
pointer.set_suppress_scroll_pointer_update(false);
update_selection_on_next_scroll = true;
}
floating_recipient_bar.update();