paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Call maybe_disable_widgets() in set_up() methods.

Browse Source 
We now rely on set_up() methods to call their
own module-specific versions of maybe_disable_widgets()
in the codepath for admin_sections.load_admin_section().

And then for live updates, we just explicitly call
all four modules that support maybe_disable_widgets().

This should make switching between sections slightly faster,
and it also reduces the risk of module A messing with
module B's state.  (Granted, we have lots of other ways
that modules can mess with each other's state.)
This commit is contained in:
Steve Howell
2018-12-08 17:16:37 +00:00
committed by Tim Abbott
parent b88a5700f6
commit 0543e8fbc1
8 changed files with 38 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/admin_sections.js
View File

@@ -4,13 +4,6 @@ var exports = {};
var is_loaded = new Dict(); // section -> bool
exports.maybe_disable_widgets = function () {
settings_org.maybe_disable_widgets();
settings_streams.maybe_disable_widgets();
settings_filters.maybe_disable_widgets();
settings_profile_fields.maybe_disable_widgets();
};
exports.load_admin_section = function (name) {
var section;
@@ -85,8 +78,6 @@ exports.load_admin_section = function (name) {
return;
}
exports.maybe_disable_widgets();
is_loaded.set(section, true);
};