paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 09:58:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

dark_theme: Refactor and consolidate theme setting logic.

Browse Source 
This commit centralizes the logic for setting a user's theme preference,
both for regular users and spectators, into the `dark_theme.ts` module.
This simplifies theme handling throughout the codebase and ensures that
the theme is set consistently across all modules.

Instead of relying on various call sites to update the recipient bar's
background color and switch between the light/dark realm logo after a
theme change, this commit modifies the `set_theme_and_update` function
to include these calls after every theme change. Before this commit,
some modules used to update the realm logo after a theme change, while
others did not. This led to inconsistencies in the UI depending on
which method was used to change the theme.
This commit is contained in:
Sayam Samal
2024-06-10 15:34:01 +05:30
committed by Tim Abbott
parent b616f013f0
commit 05c61037c8
6 changed files with 69 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/server_events_dispatch.js
View File

@@ -791,17 +791,7 @@ export function dispatch_normal_event(event) {
}
if (event.property === "color_scheme") {
requestAnimationFrame(() => {
if (event.value === settings_config.color_scheme_values.night.code) {
dark_theme.enable();
realm_logo.render();
} else if (event.value === settings_config.color_scheme_values.day.code) {
dark_theme.disable();
realm_logo.render();
} else {
dark_theme.default_preference_checker();
realm_logo.render();
}
message_lists.update_recipient_bar_background_color();
dark_theme.set_theme_and_update(event.value);
});
}
if (event.property === "starred_message_counts") {