paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Improve typing in custom_check_file() in custom_check.py.

Browse Source
This commit is contained in:
neiljp (Neil Pilgrim)
2017-08-07 19:13:25 -07:00
parent d63733077f
commit 05ef052ef5
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/linter_lib/custom_check.py
View File

@@ -9,13 +9,13 @@ import traceback
from .printer import print_err, colors from .printer import print_err, colors
from typing import cast, Any, Callable, Dict, List, Optional, Tuple from typing import cast, Any, Callable, Dict, List, Optional, Tuple, Iterable
RuleList = List[Dict[str, Any]] # mypy currently requires Aliases at global scope RuleList = List[Dict[str, Any]] # mypy currently requires Aliases at global scope
# https://github.com/python/mypy/issues/3145 # https://github.com/python/mypy/issues/3145
def custom_check_file(fn, identifier, rules, color, skip_rules=None, max_length=None): def custom_check_file(fn, identifier, rules, color, skip_rules=None, max_length=None):
# type: (str, str, RuleList, str, Optional[Any], Optional[int]) -> bool # type: (str, str, RuleList, str, Optional[Iterable[str]], Optional[int]) -> bool
failed = False failed = False
line_tups = [] line_tups = []
@@ -23,8 +23,8 @@ def custom_check_file(fn, identifier, rules, color, skip_rules=None, max_length=
line_newline_stripped = line.strip('\n') line_newline_stripped = line.strip('\n')
line_fully_stripped = line_newline_stripped.strip() line_fully_stripped = line_newline_stripped.strip()
skip = False skip = False
for rule in skip_rules or []: for skip_rule in skip_rules or []:
if re.match(rule, line): if re.match(skip_rule, line):
skip = True skip = True
if line_fully_stripped.endswith(' # nolint'): if line_fully_stripped.endswith(' # nolint'):
continue continue