paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 03:53:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

typing_events: Fix early read of page_params.

Browse Source 
For spectators,
page_params.server_typing_started_expiry_period_milliseconds has not
been initialized yet at module load time.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2023-12-30 16:12:04 -08:00
committed by Tim Abbott
parent 45c8dcc9c3
commit 06d439e0b2
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/typing_events.js
View File

@@ -15,10 +15,6 @@ import * as typing_data from "./typing_data";
//
// We also handle the local event of re-narrowing.
// (For the outbound code, see typing.js.)
//
// How long before we assume a client has gone away
// and expire the active typing indicator.
const typing_started_expiry_period = page_params.server_typing_started_expiry_period_milliseconds;
// If number of users typing exceed this,
// we render "Several people are typing..."
@@ -115,7 +111,11 @@ export function display_notification(event) {
render_notifications_for_narrow();
typing_data.kickstart_inbound_timer(key, typing_started_expiry_period, () => {
typing_data.kickstart_inbound_timer(
key,
page_params.server_typing_started_expiry_period_milliseconds,
() => {
hide_notification(event);
});
},
);
}