paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Fix Optional typing in do_update_message_flags.

Browse Source 
Fixes #5746.
This commit is contained in:
Tim Abbott
2017-07-18 10:59:56 -07:00
parent 1ed35be88c
commit 0718eb5220
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/lib/actions.py
View File

@@ -2603,7 +2603,7 @@ def do_update_pointer(user_profile, pointer, update_flags=False):
send_event(event, [user_profile.id]) send_event(event, [user_profile.id])
def do_update_message_flags(user_profile, operation, flag, messages, all, stream_obj, topic_name): def do_update_message_flags(user_profile, operation, flag, messages, all, stream_obj, topic_name):
# type: (UserProfile, Text, Text, Sequence[int], bool, Optional[Stream], Optional[Text]) -> int # type: (UserProfile, Text, Text, Optional[Sequence[int]], bool, Optional[Stream], Optional[Text]) -> int
flagattr = getattr(UserMessage.flags, flag) flagattr = getattr(UserMessage.flags, flag)
if all: if all:
@@ -2618,6 +2618,7 @@ def do_update_message_flags(user_profile, operation, flag, messages, all, stream
else: else:
msgs = UserMessage.objects.filter(message__recipient=recipient, user_profile=user_profile) msgs = UserMessage.objects.filter(message__recipient=recipient, user_profile=user_profile)
else: else:
assert messages is not None
msgs = UserMessage.objects.filter(user_profile=user_profile, msgs = UserMessage.objects.filter(user_profile=user_profile,
message__id__in=messages) message__id__in=messages)
# Hack to let you star any message # Hack to let you star any message