paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-29 19:13:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

logging_handlers: Remove STAGING_ERROR_NOTIFICATIONS setting.

Browse Source 
Running notify_server_error directly from the logging handler can lead
to database queries running in a random context.  Among the many
potential problems that could cause, one actual problem is a
SynchronousOnlyOperation exception when running in an asyncio event
loop.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-07-06 17:04:24 -07:00
committed by Tim Abbott
parent 58d9975cca
commit 07fef56c74
5 changed files with 23 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zproject/default_settings.py
View File

@@ -403,8 +403,6 @@ LOG_API_EVENT_TYPES = False
# the server.
# TODO: Replace this with a smarter "run on only one server" system.
STAGING = False
# Configuration option for our email/Zulip error reporting.
STAGING_ERROR_NOTIFICATIONS = False
# How long to wait before presence should treat a user as offline.
# TODO: Figure out why this is different from the corresponding