paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji: Write "original" file before attempting resize.

Browse Source 
Resizing emoji can fail, especially for animated GIFs; in such cases,
it is useful to have the original data on hand, to be able to dissect
the failure.
This commit is contained in:
Alex Vandiver
2022-07-06 13:23:24 -07:00
committed by Tim Abbott
parent de31114d70
commit 0830d5e7ea
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/lib/upload.py
View File

@@ -716,7 +716,6 @@ class S3UploadBackend(ZulipUploadBackend):
)
image_data = emoji_file.read()
resized_image_data, is_animated, still_image_data = resize_emoji(image_data)
upload_image_to_s3(
self.avatar_bucket,
".".join((emoji_path, "original")),
@@ -724,6 +723,8 @@ class S3UploadBackend(ZulipUploadBackend):
user_profile,
image_data,
)
resized_image_data, is_animated, still_image_data = resize_emoji(image_data)
upload_image_to_s3(
self.avatar_bucket,
emoji_path,
@@ -989,8 +990,8 @@ class LocalUploadBackend(ZulipUploadBackend):
)
image_data = emoji_file.read()
resized_image_data, is_animated, still_image_data = resize_emoji(image_data)
write_local_file("avatars", ".".join((emoji_path, "original")), image_data)
resized_image_data, is_animated, still_image_data = resize_emoji(image_data)
write_local_file("avatars", emoji_path, resized_image_data)
if is_animated:
assert still_image_data is not None