paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_tornado: Fix IOLoop exceptions output spam.

Browse Source 
We weren't quite following the proper protocol for Tornado tests.
This commit is contained in:
Tim Abbott
2017-10-27 16:28:33 -07:00
parent f790e667b3
commit 090563fb25
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/tests/test_tornado.py
View File

@@ -178,12 +178,8 @@ class WebSocketBaseTestCase(AsyncHTTPTestCase, ZulipTestCase):
def close(self, ws):
# type: (Any) -> None
"""Close a websocket connection and wait for the server side.
If we don't wait here, there are sometimes leak warnings in the
tests.
"""
ws.close()
self.wait()
class TornadoTestCase(WebSocketBaseTestCase):
@override_settings(DEBUG=False)
@@ -305,7 +301,7 @@ class TornadoTestCase(WebSocketBaseTestCase):
ws = yield self.ws_connect('/sockjs/366/v8nw22qe/websocket', cookie_header=cookie_header)
response = yield ws.read_message()
self.assertEqual(response, 'o')
self.close(ws)
yield self.close(ws)
@gen_test
def test_tornado_auth(self):
@@ -339,7 +335,7 @@ class TornadoTestCase(WebSocketBaseTestCase):
},
"type": "response"}
])
self.close(ws)
yield self.close(ws)
@gen_test
def test_sending_private_message(self):
@@ -374,7 +370,7 @@ class TornadoTestCase(WebSocketBaseTestCase):
ack_resp = yield ws.read_message()
msg_resp = yield ws.read_message()
self._check_message_sending(request_id, ack_resp, msg_resp, user_profile, queue_events_data)
self.close(ws)
yield self.close(ws)
@gen_test
def test_sending_stream_message(self):
@@ -409,4 +405,4 @@ class TornadoTestCase(WebSocketBaseTestCase):
ack_resp = yield ws.read_message()
msg_resp = yield ws.read_message()
self._check_message_sending(request_id, ack_resp, msg_resp, user_profile, queue_events_data)
self.close(ws)
yield self.close(ws)