paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

i18n: Tweak args/kwargs for get_default_language_for_new_user.

Browse Source 
Making request a mandatory kwarg avoids confusion about the meaning of
parameters, especially with `request` acquiring the ability to be None
in the upcoming next commit.
This commit is contained in:
Mateusz Mandera
2023-10-01 20:24:43 +02:00
committed by Tim Abbott
parent a802f0f339
commit 092ecbacc6
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_signup.py
View File

@@ -3953,17 +3953,17 @@ class UserSignUpTest(ZulipTestCase):
realm = get_realm("zulip")
req = HostRequestMock()
req.META["HTTP_ACCEPT_LANGUAGE"] = "de,en"
self.assertEqual(get_default_language_for_new_user(req, realm), "de")
self.assertEqual(get_default_language_for_new_user(realm, request=req), "de")
do_set_realm_property(realm, "default_language", "hi", acting_user=None)
realm.refresh_from_db()
req = HostRequestMock()
req.META["HTTP_ACCEPT_LANGUAGE"] = "de,en"
self.assertEqual(get_default_language_for_new_user(req, realm), "de")
self.assertEqual(get_default_language_for_new_user(realm, request=req), "de")
req = HostRequestMock()
req.META["HTTP_ACCEPT_LANGUAGE"] = ""
self.assertEqual(get_default_language_for_new_user(req, realm), "hi")
self.assertEqual(get_default_language_for_new_user(realm, request=req), "hi")
class DeactivateUserTest(ZulipTestCase):