paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

/team: Use list instead of dict for contributors data.

Browse Source
This commit is contained in:
Tommy Ip
2017-11-20 20:49:03 +00:00
committed by Tim Abbott
parent 771abf4179
commit 09d103091d
1 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tools/update-authors-json
View File

@@ -39,9 +39,10 @@ parser.add_argument('--not-required', action='store_true', default=False,
help='Consider failures to reach GitHub nonfatal') help='Consider failures to reach GitHub nonfatal')
args = parser.parse_args() args = parser.parse_args()
ContributorsJSON = TypedDict('ContributorsJSON', { ContributorsJSON = TypedDict('ContributorsJSON', {
'date': str, 'date': str,
'contrib': Dict[str, Dict[str, Union[str, int]]], 'contrib': List[Dict[str, Union[str, int]]],
}) })
@@ -61,9 +62,9 @@ def write_to_disk(json_data: ContributorsJSON, out_file: str) -> None:
def run_production() -> None: def run_production() -> None:
""" """
Get contributors data from Github and insert them into a temporaril Get contributors data from Github and insert them into a temporary
dictionary. Retry fetching each repository if responded with non HTTP dictionary. Retry fetching each repository if responded with non HTTP 200
200 status. status.
""" """
repositories = { repositories = {
'server': 'https://api.github.com/repos/zulip/zulip/stats/contributors', 'server': 'https://api.github.com/repos/zulip/zulip/stats/contributors',
@@ -73,27 +74,27 @@ def run_production() -> None:
'zulipbot': 'https://api.github.com/repos/zulip/zulipbot/stats/contributors', 'zulipbot': 'https://api.github.com/repos/zulip/zulipbot/stats/contributors',
} }
data = dict(date=str(date.today()), contrib={}) # type: ContributorsJSON data = dict(date=str(date.today()), contrib=[]) # type: ContributorsJSON
contribs_data = {} # type: Dict[str, Dict[str, Union[str, int]]] contribs_list = {} # type: Dict[str, Dict[str, Union[str, int]]]
for t in range(args.max_retries): for _ in range(args.max_retries):
repo_done = [] repos_done = []
for k, v in repositories.items(): for name, link in repositories.items():
contribs = fetch_contributors(v) contribs = fetch_contributors(link)
if contribs: if contribs:
repo_done.append(k) repos_done.append(name)
for contrib in contribs: for contrib in contribs:
username = contrib.get('author').get('login') username = contrib.get('author').get('login')
contrib_data = { contrib_data = {
'avatar': contrib.get('author').get('avatar_url'), 'avatar': contrib.get('author').get('avatar_url'),
k: contrib.get('total'), name: contrib.get('total'),
} }
if username in contribs_data: if username in contribs_list:
contribs_data[username].update(contrib_data) contribs_list[username].update(contrib_data)
else: else:
contribs_data[username] = contrib_data contribs_list[username] = contrib_data
for k in repo_done: for repo in repos_done:
del repositories[k] del repositories[repo]
if not repositories: if not repositories:
break break
@@ -105,7 +106,9 @@ def run_production() -> None:
if not args.not_required: if not args.not_required:
sys.exit(1) sys.exit(1)
data['contrib'] = contribs_data for contributor_name, contributor_data in contribs_list.items():
contributor_data['name'] = contributor_name
data['contrib'].append(contributor_data)
write_to_disk(data, settings.CONTRIBUTORS_DATA) write_to_disk(data, settings.CONTRIBUTORS_DATA)