paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

github_webhook: throw an exception on unhandled events types.

Browse Source
This commit is contained in:
Tomasz Kolek
2016-04-20 21:34:16 +02:00
committed by Tim Abbott
parent fafc9cb742
commit 09e40b27c2
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
zerver/views/webhooks/github.py
View File

@@ -16,6 +16,10 @@ ZULIP_TEST_REPO_ID = 6893087
def is_test_repository(repository): def is_test_repository(repository):
return repository['name'] == ZULIP_TEST_REPO_NAME and repository['id'] == ZULIP_TEST_REPO_ID return repository['name'] == ZULIP_TEST_REPO_NAME and repository['id'] == ZULIP_TEST_REPO_ID
class UnknownEventType(Exception):
pass
def github_generic_subject(noun, topic_focus, blob): def github_generic_subject(noun, topic_focus, blob):
# issue and pull_request objects have the same fields we're interested in # issue and pull_request objects have the same fields we're interested in
return "%s: %s %d: %s" % (topic_focus, noun, blob['number'], blob['title']) return "%s: %s %d: %s" % (topic_focus, noun, blob['number'], blob['title'])
@@ -113,6 +117,9 @@ def api_github_v2(user_profile, event, payload, branches, default_stream, commit
content += "\n\n~~~ quote\n%s\n~~~" % (comment['body'],) content += "\n\n~~~ quote\n%s\n~~~" % (comment['body'],)
else:
raise UnknownEventType(u'Event %s is unknown and cannot be handled' % (event,))
return target_stream, subject, content return target_stream, subject, content
@authenticated_api_view @authenticated_api_view