From 0a0ac24d62d695b6ac0d45e283b896215f4b0b8e Mon Sep 17 00:00:00 2001
From: Tim Abbott <tabbott@zulipchat.com>
Date: Thu, 28 Feb 2019 15:15:21 -0800
Subject: [PATCH] settings: Disable autocomplete on various text fields.

This prevents browser autocomplete from annoying trying to insert
values into these settings fields.
---
 .../settings/organization-profile-admin.handlebars          | 1 +
 .../settings/organization-settings-admin.handlebars         | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/static/templates/settings/organization-profile-admin.handlebars b/static/templates/settings/organization-profile-admin.handlebars
index f7d1052354..48c7382a7a 100644
--- a/static/templates/settings/organization-profile-admin.handlebars
+++ b/static/templates/settings/organization-profile-admin.handlebars
@@ -16,6 +16,7 @@
                 <div class="input-group admin-realm">
                     <label for="id_realm_name">{{t "Organization name" }}</label>
                     <input type="text" id="id_realm_name" name="realm_name" class="admin-realm-name"
+                      autocomplete="off"
                       value="{{ realm_name }}" maxlength="40" />
                 </div>
                 <div class="input-group admin-realm">
diff --git a/static/templates/settings/organization-settings-admin.handlebars b/static/templates/settings/organization-settings-admin.handlebars
index 706d2ed900..3616976fc3 100644
--- a/static/templates/settings/organization-settings-admin.handlebars
+++ b/static/templates/settings/organization-settings-admin.handlebars
@@ -23,6 +23,7 @@
                         <input type="text" id="id_realm_message_content_edit_limit_minutes"
                           name="realm_message_content_edit_limit_minutes"
                           class="admin-realm-time-limit-input"
+                          autocomplete="off"
                           value="{{ realm_message_content_edit_limit_minutes }}"/>
                     </div>
                 </div>
@@ -57,6 +58,7 @@
                         <input type="text" id="id_realm_message_content_delete_limit_minutes"
                           name="realm_message_content_delete_limit_minutes"
                           class="admin-realm-time-limit-input"
+                          autocomplete="off"
                           value="{{ realm_message_content_delete_limit_minutes }}"/>
                     </div>
                 </div>
@@ -163,6 +165,7 @@
                         <label>{{t 'Domain for your <a href="https://gsuite.google.com" target="_blank">G Suite team</a> (required)' }}:</label>
                         <input type="text" id="id_realm_google_hangouts_domain"
                           name="realm_google_hangouts_domain"
+                          autocomplete="off"
                           class="admin-realm-google-hangouts-domain"/>
                     </div>
                     <div id="zoom_help_text" class="zoom_credentials">
@@ -175,18 +178,21 @@
                         <label>{{t 'Zoom user ID or email address (required)' }}:</label>
                         <input type="text" id="id_realm_zoom_user_id"
                           name="realm_zoom_user_id"
+                          autocomplete="off"
                           class="admin-realm-zoom-field"/>
                     </div>
                     <div id="zoom_api_key" class="zoom_credentials">
                         <label>{{t 'Zoom API key (required)' }}:</label>
                         <input type="text" id="id_realm_zoom_api_key"
                           name="realm_zoom_api_key"
+                          autocomplete="off"
                           class="admin-realm-zoom-field"/>
                     </div>
                     <div id="zoom_api_secret" class="zoom_credentials">
                         <label>{{t 'Zoom API secret (required)' }}:</label>
                         <input type="text" id="id_realm_zoom_api_secret"
                           name="realm_zoom_api_secret"
+                          autocomplete="off"
                           class="admin-realm-zoom-field"/>
                     </div>
                 </div>