paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream-settings: Live update visibility of folder dropdown.

Browse Source 
An error was raised where we tried to live update the folder name
in folder dropdown even when there was no dropdown visible
to the non-admin user in settings page. This was because
"There are no channel folders configured in this organization."
text was shown even when a folder was recently created in the
realm as we did not live update the visibility of dropdown on
creating or archiving a folder.

This commit fixes the bug by live-updating the visibility
of folder dropdown when creating or archiving a folder.
This commit is contained in:
Sahil Batra
2025-08-14 09:28:40 +05:30
committed by Tim Abbott
parent 331d210dac
commit 0a8238b993
7 changed files with 52 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/tests/dispatch.test.cjs
View File

@@ -555,8 +555,12 @@ run_test("channel_folders", ({override}) => {
let event = event_fixtures.channel_folder__add;
{
const stub = make_stub();
override(stream_ui_updates, "update_folder_dropdown_visibility", stub.f);
dispatch(event);
assert.equal(stub.num_calls, 1);
const folders = channel_folders.get_channel_folders();
assert.equal(folders.length, 1);
assert.equal(folders[0].id, event.channel_folder.id);
@@ -569,10 +573,17 @@ run_test("channel_folders", ({override}) => {
override(stream_settings_ui, "update_channel_folder_name", stub.f);
override(stream_list, "update_streams_sidebar", stub.f);
override(stream_settings_ui, "reset_dropdown_set_to_archived_folder", stub.f);
const update_dropdown_visibility_stub = make_stub();
override(
stream_ui_updates,
"update_folder_dropdown_visibility",
update_dropdown_visibility_stub.f,
);
dispatch(event);
assert.equal(stub.num_calls, 3);
assert.equal(update_dropdown_visibility_stub.num_calls, 1);
const folders = channel_folders.get_channel_folders(true);
const args = stub.get_args("folder_id");
assert_same(args.folder_id, event.channel_folder_id);