mirror of
https://github.com/zulip/zulip.git
synced 2025-10-23 04:52:12 +00:00
blueslip: Untangle from page_params.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
committed by
Tim Abbott
parent
f7eecb0e03
commit
0b3cf78333
@@ -247,6 +247,7 @@ module.exports = {
|
||||
node: false,
|
||||
},
|
||||
globals: {
|
||||
DEVELOPMENT: false,
|
||||
ZULIP_VERSION: false,
|
||||
},
|
||||
rules: {
|
||||
|
@@ -9,7 +9,6 @@
|
||||
import * as Sentry from "@sentry/browser";
|
||||
import $ from "jquery";
|
||||
|
||||
import {page_params} from "./base_page_params";
|
||||
import {BlueslipError, display_stacktrace} from "./blueslip_stacktrace";
|
||||
|
||||
if (Error.stackTraceLimit !== undefined) {
|
||||
@@ -81,7 +80,7 @@ export function info(msg: string, more_info?: unknown): void {
|
||||
export function warn(msg: string, more_info?: unknown): void {
|
||||
const args = build_arg_list(msg, more_info);
|
||||
logger.warn(...args);
|
||||
if (page_params.development_environment) {
|
||||
if (DEVELOPMENT) {
|
||||
console.trace();
|
||||
}
|
||||
}
|
||||
@@ -100,7 +99,7 @@ export function error(msg: string, more_info?: object | undefined, original_erro
|
||||
logger.error(...args);
|
||||
|
||||
// Throw an error in development; this will show a dialog (see below).
|
||||
if (page_params.development_environment) {
|
||||
if (DEVELOPMENT) {
|
||||
throw new BlueslipError(msg, more_info, original_error);
|
||||
}
|
||||
// This function returns to its caller in production! To raise a
|
||||
@@ -109,7 +108,7 @@ export function error(msg: string, more_info?: object | undefined, original_erro
|
||||
|
||||
// Install a window-wide onerror handler in development to display the stacktraces, to make them
|
||||
// hard to miss
|
||||
if (page_params.development_environment) {
|
||||
if (DEVELOPMENT) {
|
||||
$(window).on("error", (event: JQuery.TriggeredEvent) => {
|
||||
const {originalEvent} = event;
|
||||
if (originalEvent instanceof ErrorEvent && originalEvent.error instanceof Error) {
|
||||
|
@@ -51,5 +51,6 @@ declare global {
|
||||
};
|
||||
}
|
||||
|
||||
const DEVELOPMENT: boolean;
|
||||
const ZULIP_VERSION: string;
|
||||
}
|
||||
|
@@ -199,6 +199,7 @@ const config = (
|
||||
},
|
||||
plugins: [
|
||||
new DefinePlugin({
|
||||
DEVELOPMENT: JSON.stringify(!production),
|
||||
ZULIP_VERSION: JSON.stringify(env.ZULIP_VERSION ?? "development"),
|
||||
}),
|
||||
new DebugRequirePlugin(),
|
||||
|
Reference in New Issue
Block a user