paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer: Take screenshot on failure.

Browse Source 
To take a screenshot on failure where we have our common error
handling code in common.run_test method we need to have access to
the Page instance. Currently, we create a new Page in the test method
we pass into run_test, so we pass in a new Page instance to that method
so the test and the run_test method have access to the same Page. And,
then we take a screenshot on failure. It will be saved as `failure-${num}`
in var/puppeteer directory.
This commit is contained in:
Priyank Patel
2020-05-16 17:14:31 +00:00
committed by Tim Abbott
parent 74e9019922
commit 0b698d1173
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/puppeteer_tests/01-login.js
View File

@@ -22,8 +22,8 @@ async function log_out(page) {
assert(page.url().includes('accounts/login/'));
}
async function login_tests() {
const page = await common.get_page(realm_url + 'login/');
async function login_tests(page) {
await page.goto(realm_url + 'login/');
await log_in(page, test_credentials.default_user);
await log_out(page);
}