paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

postprocess_content: Simplify and clarify video logic.

Browse Source
This commit is contained in:
Tim Abbott
2025-09-17 13:24:37 -07:00
parent d8e58f31b9
commit 0c04f5f101
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
web/src/postprocess_content.ts
View File

@@ -53,30 +53,30 @@ export function postprocess_content(html: string): string {
} }
if (elt.querySelector("img") || elt.querySelector("video")) { if (elt.querySelector("img") || elt.querySelector("video")) {
// Rewrite the legacy .message_inline_image class, whose name would add
// confusion when Zulip supports inline images via standard Markdown.
// We further adjust this class below for when the element contains a
// video.
elt.parentElement?.classList.replace(
"message_inline_image",
"message-media-preview-image",
);
// We want a class to refer to media links // We want a class to refer to media links
elt.classList.add("media-anchor-element"); elt.classList.add("media-anchor-element");
// Add a class to the video, if it exists, including
// the .media-image-element class for properly treating // Replace the legacy .message_inline_image class, whose
// video thumbnails // name would add confusion when Zulip supports inline
// images via standard Markdown, with dedicated classes
// for video and image previews.
if (elt.querySelector("video")) { if (elt.querySelector("video")) {
// We use a different class name to distinguish videos from images
elt.parentElement?.classList.replace( elt.parentElement?.classList.replace(
"message-media-preview-image", "message_inline_image",
"message-media-preview-video", "message-media-preview-video",
); );
elt elt
.querySelector("video") .querySelector("video")
?.classList.add("media-video-element", "media-image-element"); ?.classList.add("media-video-element", "media-image-element");
} else {
elt.parentElement?.classList.replace(
"message_inline_image",
"message-media-preview-image",
);
} }
// Add a class to the image, if it exists
// This code path adds the media-image-element class to
// both image preview elements and video thumbnails.
if (elt.querySelector("img")) { if (elt.querySelector("img")) {
elt.querySelector("img")?.classList.add("media-image-element"); elt.querySelector("img")?.classList.add("media-image-element");
} }