paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Add notifications for permission policy changes.

Browse Source 
The change to curl_param_value_generators.py warrants a brief
explanation. Stream permission changes now generate a notification
message. Our curl example test for removing a reaction comes after
the two tests for updating the stream permission changes, thus the
hardcoded message ID in that test needs to be incremented by 2 to
account for the two notification messages that now come before it.

This is a part of #20289.
This commit is contained in:
Eeshan Garg
2021-12-10 18:41:25 -05:00
committed by Tim Abbott
parent fab1b7f5d5
commit 0d99809fd3
11 changed files with 244 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
zerver/tests/test_message_topics.py
View File

@@ -132,7 +132,9 @@ class TopicHistoryTest(ZulipTestCase):
)
# Now make stream private, but subscribe cordelia
do_change_stream_permission(stream, invite_only=True)
do_change_stream_permission(
stream, invite_only=True, acting_user=self.example_user("cordelia")
)
self.subscribe(self.example_user("cordelia"), stream.name)
result = self.client_get(endpoint, {})
@@ -231,10 +233,12 @@ class TopicDeleteTest(ZulipTestCase):
},
)
self.assert_json_error(result, "Must be an organization administrator")
self.assertEqual(self.get_last_message().id, last_msg_id)
self.assertTrue(Message.objects.filter(id=last_msg_id).exists())
# Make stream private with limited history
do_change_stream_permission(stream, invite_only=True, history_public_to_subscribers=False)
do_change_stream_permission(
stream, invite_only=True, history_public_to_subscribers=False, acting_user=user_profile
)
# ADMIN USER subscribed now
user_profile = self.example_user("iago")
@@ -252,7 +256,7 @@ class TopicDeleteTest(ZulipTestCase):
},
)
self.assert_json_success(result)
self.assertEqual(self.get_last_message().id, last_msg_id)
self.assertTrue(Message.objects.filter(id=last_msg_id).exists())
# Try to delete all messages in the topic again. There are no messages accessible
# to the administrator, so this should do nothing.
@@ -263,10 +267,12 @@ class TopicDeleteTest(ZulipTestCase):
},
)
self.assert_json_success(result)
self.assertEqual(self.get_last_message().id, last_msg_id)
self.assertTrue(Message.objects.filter(id=last_msg_id).exists())
# Make the stream's history public to subscribers
do_change_stream_permission(stream, invite_only=True, history_public_to_subscribers=True)
do_change_stream_permission(
stream, invite_only=True, history_public_to_subscribers=True, acting_user=user_profile
)
# Delete the topic should now remove all messages
result = self.client_post(
endpoint,
@@ -275,7 +281,8 @@ class TopicDeleteTest(ZulipTestCase):
},
)
self.assert_json_success(result)
self.assertEqual(self.get_last_message().id, initial_last_msg_id)
self.assertFalse(Message.objects.filter(id=last_msg_id).exists())
self.assertTrue(Message.objects.filter(id=initial_last_msg_id).exists())
# Delete again, to test the edge case of deleting an empty topic.
result = self.client_post(
@@ -285,4 +292,5 @@ class TopicDeleteTest(ZulipTestCase):
},
)
self.assert_json_success(result)
self.assertEqual(self.get_last_message().id, initial_last_msg_id)
self.assertFalse(Message.objects.filter(id=last_msg_id).exists())
self.assertTrue(Message.objects.filter(id=initial_last_msg_id).exists())