paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

widgets: Rename confusing variable name in tabbed_instructions.ts.

Browse Source 
The `tabbed_instructions` widget used for both language toggles in our
API documentation and app toggles in our Help Center documentation
misleadingly calls the identifier for the tab `language` in local
variables and its interface.

- Renames local variables `language` -> `tab_key`.
- Renames HTML data attributes `data-language` -> `data-tab-key`.

Fixes #24669.
This commit is contained in:
David Rosa
2023-06-21 20:38:17 -05:00
committed by Tim Abbott
parent ec4bfd7c78
commit 0e0512df92
4 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zerver/tests/test_templates.py
View File

@@ -38,14 +38,14 @@ header
<p>
<div class="code-section has-tabs" markdown="1">
<ul class="nav">
<li data-language="ios" tabindex="0">iOS</li>
<li data-language="desktop-web" tabindex="0">Desktop/Web</li>
<li data-tab-key="ios" tabindex="0">iOS</li>
<li data-tab-key="desktop-web" tabindex="0">Desktop/Web</li>
</ul>
<div class="blocks">
<div data-language="ios" markdown="1"></p>
<div data-tab-key="ios" markdown="1"></p>
<p>iOS instructions</p>
<p></div>
<div data-language="desktop-web" markdown="1"></p>
<div data-tab-key="desktop-web" markdown="1"></p>
<p>Desktop/browser instructions</p>
<p></div>
</div>
@@ -56,14 +56,14 @@ header
<p>
<div class="code-section has-tabs" markdown="1">
<ul class="nav">
<li data-language="desktop-web" tabindex="0">Desktop/Web</li>
<li data-language="android" tabindex="0">Android</li>
<li data-tab-key="desktop-web" tabindex="0">Desktop/Web</li>
<li data-tab-key="android" tabindex="0">Android</li>
</ul>
<div class="blocks">
<div data-language="desktop-web" markdown="1"></p>
<div data-tab-key="desktop-web" markdown="1"></p>
<p>Desktop/browser instructions</p>
<p></div>
<div data-language="android" markdown="1"></p>
<div data-tab-key="android" markdown="1"></p>
<p>Android instructions</p>
<p></div>
</div>
@@ -74,10 +74,10 @@ header
<p>
<div class="code-section no-tabs" markdown="1">
<ul class="nav">
<li data-language="instructions-for-all-platforms" tabindex="0">Instructions for all platforms</li>
<li data-tab-key="instructions-for-all-platforms" tabindex="0">Instructions for all platforms</li>
</ul>
<div class="blocks">
<div data-language="instructions-for-all-platforms" markdown="1"></p>
<div data-tab-key="instructions-for-all-platforms" markdown="1"></p>
<p>Instructions for all platforms</p>
<p></div>
</div>