From 0ea04f31bc898b0246e83cad01e0be651542d1aa Mon Sep 17 00:00:00 2001 From: Alya Abbott Date: Fri, 26 Sep 2025 09:23:17 -0700 Subject: [PATCH] compose and feed: Improve label for DMs to yourself. --- web/src/compose_ui.ts | 2 +- web/src/narrow_banner.ts | 3 +-- web/templates/reply_recipient_label.hbs | 2 +- web/tests/compose_closed_ui.test.cjs | 2 +- web/tests/message_view.test.cjs | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/web/src/compose_ui.ts b/web/src/compose_ui.ts index 93c229c158..5e949e1755 100644 --- a/web/src/compose_ui.ts +++ b/web/src/compose_ui.ts @@ -460,7 +460,7 @@ export function compute_placeholder_text(opts: ComposePlaceholderOptions): strin } else if (opts.direct_message_user_ids.length > 0) { const user_ids = opts.direct_message_user_ids; if (people.is_direct_message_conversation_with_self(user_ids)) { - return $t({defaultMessage: "Message yourself"}); + return $t({defaultMessage: "Write yourself a note"}); } const users = people.get_users_from_ids(user_ids); const recipient_parts = users.map((user) => { diff --git a/web/src/narrow_banner.ts b/web/src/narrow_banner.ts index 3f49f9265b..604eeae941 100644 --- a/web/src/narrow_banner.ts +++ b/web/src/narrow_banner.ts @@ -373,8 +373,7 @@ export function pick_empty_narrow_banner(current_filter: Filter): NarrowBannerDa if (people.is_my_user_id(recipient_user.user_id)) { return { title: $t({ - defaultMessage: - "You have not sent any direct messages to yourself yet!", + defaultMessage: "You haven't sent yourself any notes yet!", }), html: $t_html({ defaultMessage: diff --git a/web/templates/reply_recipient_label.hbs b/web/templates/reply_recipient_label.hbs index da202e3314..d463a4e5ca 100644 --- a/web/templates/reply_recipient_label.hbs +++ b/web/templates/reply_recipient_label.hbs @@ -1,6 +1,6 @@ {{#if is_dm_with_self}} {{#tr}} - Message yourself + Write yourself a note {{/tr}} {{else}} {{#tr}} diff --git a/web/tests/compose_closed_ui.test.cjs b/web/tests/compose_closed_ui.test.cjs index 32607833b0..81695313dc 100644 --- a/web/tests/compose_closed_ui.test.cjs +++ b/web/tests/compose_closed_ui.test.cjs @@ -222,7 +222,7 @@ run_test("test_non_message_list_input", () => { user_ids: [current_user.user_id], }); let label = $("#left_bar_compose_reply_button_big").html(); - assert.equal(label, "Message yourself"); + assert.equal(label, "Write yourself a note"); // Invalid data for a the reply button text. compose_closed_ui.update_recipient_text_for_reply_button({ diff --git a/web/tests/message_view.test.cjs b/web/tests/message_view.test.cjs index ad396a0037..adeaa23fb1 100644 --- a/web/tests/message_view.test.cjs +++ b/web/tests/message_view.test.cjs @@ -472,7 +472,7 @@ run_test("show_empty_narrow_message", ({mock_template, override}) => { assert.equal( $(".empty_feed_notice_main").html(), empty_narrow_html( - "translated: You have not sent any direct messages to yourself yet!", + "translated: You haven't sent yourself any notes yet!", "translated HTML: Use this space for personal notes, or to test out Zulip features.", ), );