paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_check: Enforce use of assert_length helper.

Browse Source
This commit is contained in:
Abhijeet Prasad Bodas
2021-05-10 20:04:23 +05:30
committed by Tim Abbott
parent 352634a851
commit 0ec905ed52
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/linter_lib/custom_check.py
View File

@@ -267,6 +267,12 @@ python_rules = RuleList(
"good_lines": ["assertEqual(1, 2)"], "good_lines": ["assertEqual(1, 2)"],
"bad_lines": ["assertEquals(1, 2)"], "bad_lines": ["assertEquals(1, 2)"],
}, },
{
"pattern": "assertEqual[(]len[(][^ ]*[)],",
"description": "Use the assert_length helper instead of assertEqual(len(..), ..).",
"good_lines": ["assert_length(data, 2)"],
"bad_lines": ["assertEqual(len(data), 2)"],
},
{ {
"pattern": r"#\s*type:\s*ignore(?!\[[^][]+\] +# +\S)", "pattern": r"#\s*type:\s*ignore(?!\[[^][]+\] +# +\S)",
"exclude": {"tools/tests", "zerver/lib/test_runner.py", "zerver/tests"}, "exclude": {"tools/tests", "zerver/lib/test_runner.py", "zerver/tests"},