paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

error_notify: Fix type narrowing of settings.ERROR_BOT.

Browse Source 
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li
2022-07-06 01:06:33 -04:00
committed by Tim Abbott
parent c5075be9aa
commit 0ef5eee3f0
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
zerver/lib/error_notify.py
View File

@@ -43,7 +43,7 @@ def deployment_repr(report: Dict[str, Any]) -> str:
def notify_browser_error(report: Dict[str, Any]) -> None:
report = defaultdict(lambda: None, report)
if settings.ERROR_BOT:
zulip_browser_error(report)
zulip_browser_error(report, settings.ERROR_BOT)
email_browser_error(report)
@@ -80,7 +80,7 @@ Deployed version: {version}
mail_admins(email_subject, body)
def zulip_browser_error(report: Dict[str, Any]) -> None:
def zulip_browser_error(report: Dict[str, Any], error_bot_email: str) -> None:
email_subject = "JS error: {user_email}".format(**report)
user_info = user_info_str(report)
@@ -89,7 +89,7 @@ def zulip_browser_error(report: Dict[str, Any]) -> None:
body += "Message: {message}\n".format(**report)
error_bot_realm = get_realm(settings.STAFF_SUBDOMAIN)
error_bot = get_system_bot(settings.ERROR_BOT, error_bot_realm.id)
error_bot = get_system_bot(error_bot_email, error_bot_realm.id)
errors_stream = get_stream("errors", error_bot_realm)
internal_send_stream_message(
@@ -104,10 +104,10 @@ def notify_server_error(report: Dict[str, Any]) -> None:
report = defaultdict(lambda: None, report)
email_server_error(report)
if settings.ERROR_BOT:
zulip_server_error(report)
zulip_server_error(report, settings.ERROR_BOT)
def zulip_server_error(report: Dict[str, Any]) -> None:
def zulip_server_error(report: Dict[str, Any], error_bot_email: str) -> None:
email_subject = "{node}: {message}".format(**report)
logger_str = logger_repr(report)
@@ -143,7 +143,7 @@ Error generated by {user_info}
{request_repr}"""
error_bot_realm = get_realm(settings.STAFF_SUBDOMAIN)
error_bot = get_system_bot(settings.ERROR_BOT, error_bot_realm.id)
error_bot = get_system_bot(error_bot_email, error_bot_realm.id)
errors_stream = get_stream("errors", error_bot_realm)
internal_send_stream_message(