paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create explicit handlers for stream activate/deactivate.

Browse Source 
Calling explicit functions ensurest that the sidebars
get activated for narrows before less important things
happen, and it also makes testing easier.
This commit is contained in:
Steve Howell
2017-08-12 10:49:10 -04:00
committed by Tim Abbott
parent 8655fae910
commit 0f3b565d40
3 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
static/js/stream_list.js
View File

@@ -492,6 +492,27 @@ exports.update_top_left_corner_for_narrow = function (filter) {
}
};
exports.handle_narrow_activated = function (filter) {
exports.update_top_left_corner_for_narrow(filter);
var stream_li = exports.update_stream_sidebar_for_narrow(filter);
if (stream_li) {
exports.scroll_stream_into_view(stream_li);
}
// Update scrollbar size.
$("#stream-filters-container").perfectScrollbar("update");
};
exports.handle_narrow_deactivated = function () {
deselect_stream_items();
deselect_top_left_corner_items();
clear_topics();
pm_list.close();
var filter_li = exports.get_global_filter_li('home');
filter_li.addClass('active-filter');
};
exports.initialize = function () {
// TODO, Eventually topic_list won't be a big singleton,
// and we can create more component-based click handlers for
@@ -501,27 +522,6 @@ exports.initialize = function () {
zoom_out: zoom_out,
});
$(document).on('narrow_activated.zulip', function (event) {
exports.update_top_left_corner_for_narrow(event.filter);
var stream_li = exports.update_stream_sidebar_for_narrow(event.filter);
if (stream_li) {
exports.scroll_stream_into_view(stream_li);
}
// Update scrollbar size.
$("#stream-filters-container").perfectScrollbar("update");
});
$(document).on('narrow_deactivated.zulip', function () {
deselect_stream_items();
deselect_top_left_corner_items();
clear_topics();
pm_list.close();
var filter_li = exports.get_global_filter_li('home');
filter_li.addClass('active-filter');
});
$(document).on('subscription_add_done.zulip', function (event) {
exports.create_sidebar_row(event.sub);
exports.build_stream_list();