From 0f85d6327db358b1656b663c86d20acf64f4fffc Mon Sep 17 00:00:00 2001 From: Shubham Padia Date: Tue, 13 May 2025 14:01:44 +0000 Subject: [PATCH] help-beta: Fix bug of not rendering font-awesome icons correctly. In `replace_icons`, when replacing zulip icons, the original `markdown_string` was being passed instead of the result from the previous font-awesome icon replacement. --- tools/convert-help-center-docs-to-mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/convert-help-center-docs-to-mdx b/tools/convert-help-center-docs-to-mdx index 0c4593e3de..37fd588192 100755 --- a/tools/convert-help-center-docs-to-mdx +++ b/tools/convert-help-center-docs-to-mdx @@ -136,7 +136,7 @@ def replace_icons(markdown_string: str, import_statement_set: set[str]) -> str: match, "zulip-icon", "ZulipIcons", import_statement_set ) - result = re.sub(zulip_icon_pattern, replace_zulip_icon_with_unplugin_component, markdown_string) + result = re.sub(zulip_icon_pattern, replace_zulip_icon_with_unplugin_component, result) return result