compatibility: Rewrite verbose test for compact legibility.

This will facilitate adding a bunch more test cases shortly.
This commit is contained in:
Greg Price
2018-12-04 15:17:02 -08:00
committed by Tim Abbott
parent 2bac6de6c6
commit 0fa4fdcff9

View File

@@ -1,4 +1,6 @@
from django.http import HttpResponse
from zerver.lib.test_classes import ZulipTestCase from zerver.lib.test_classes import ZulipTestCase
from zerver.views.compatibility import find_mobile_os, version_lt from zerver.views.compatibility import find_mobile_os, version_lt
@@ -59,7 +61,8 @@ class VersionTest(ZulipTestCase):
class CompatibilityTest(ZulipTestCase): class CompatibilityTest(ZulipTestCase):
def test_compatibility(self) -> None: def test_compatibility(self) -> None:
result = self.client_get("/compatibility", HTTP_USER_AGENT='ZulipMobile/5.0') def get(user_agent: str) -> HttpResponse:
self.assert_json_success(result) return self.client_get("/compatibility", HTTP_USER_AGENT=user_agent)
result = self.client_get("/compatibility", HTTP_USER_AGENT='ZulipInvalid/5.0')
self.assert_json_error(result, "Client is too old") self.assert_json_success(get('ZulipMobile/5.0'))
self.assert_json_error(get('ZulipInvalid/5.0'), "Client is too old")