paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_fetch: Switch to exponential backoff with jitter.

Browse Source
This commit is contained in:
Alex Vandiver
2022-10-17 18:41:38 -04:00
committed by Tim Abbott
parent 3bb13a1f58
commit 0fc8c6c16f
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/message_fetch.js
View File

@@ -19,7 +19,6 @@ import * as ui_report from "./ui_report";
const consts = { const consts = {
backfill_idle_time: 10 * 1000, backfill_idle_time: 10 * 1000,
error_retry_time: 5000,
backfill_batch_size: 1000, backfill_batch_size: 1000,
narrow_before: 50, narrow_before: 50,
narrow_after: 50, narrow_after: 50,
@@ -177,7 +176,7 @@ function handle_operators_supporting_id_based_api(data) {
return data; return data;
} }
export function load_messages(opts) { export function load_messages(opts, attempt = 1) {
if (typeof opts.anchor === "number") { if (typeof opts.anchor === "number") {
// Messages that have been locally echoed messages have // Messages that have been locally echoed messages have
// floating point temporary IDs, which is intended to be a. // floating point temporary IDs, which is intended to be a.
@@ -286,11 +285,15 @@ export function load_messages(opts) {
return; return;
} }
// We might want to be more clever here // Backoff on retries, with full jitter: up to 2s, 4s, 8s, 16s, 32s
let delay = Math.random() * 2 ** attempt * 2000;
if (attempt >= 5) {
delay = 30000;
}
ui_report.show_error($("#connection-error")); ui_report.show_error($("#connection-error"));
setTimeout(() => { setTimeout(() => {
load_messages(opts); load_messages(opts, attempt + 1);
}, consts.error_retry_time); }, delay);
}, },
}); });
} }