paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_tooltips: Improve tooltip logic for compose_reply_button.

Browse Source 
Change compose_reply_button tooltip logic to show the correct tooltip.
Earlier in organizations where DMs were disabled, a stale tooltip was
being displayed.

Earlier if the user hovered over the compose_reply_button when it was
disabled and switched to a stream in which it was enabled before waiting
for the tooltip delay, the next time the user hovers over the
compose_reply_button the stale disabled tooltip is displayed instead of
the enabled one.

This is fixed by checking if the compose_reply_button is enabled on the
fly while rendering the tooltip via instance.setContent().

Fixes #29238.
This commit is contained in:
Kenneth Rodrigues
2024-04-09 11:26:36 +05:30
committed by Tim Abbott
parent 47e9e770a6
commit 110ca73545
3 changed files with 53 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/templates/compose.hbs
View File

@@ -13,7 +13,7 @@
<div id="compose_controls" class="new-style">
<div id="compose_buttons">
<div class="new_message_button reply_button_container">
<div class="compose-reply-button-wrapper" data-tooltip-template-id="compose_reply_message_button_tooltip_template">
<div class="compose-reply-button-wrapper" data-reply-button-type="selected_message">
<button type="button" class="button small compose_reply_button"
id="left_bar_compose_reply_button_big">
{{t 'Compose message' }}