paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 01:16:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

composebox_typeahead: Open typeahead immediately when @ is entered.

Browse Source 
This change ensures that we pop up the typeahead when one
has entered just `@`. This will make clear to the user
about the @-mentions feature in Zulip.
This also makes us consistent with expectations from other
chatting apps like Slack, Discord, etc.

Added few test cases and modified the present ones.

Fixes: #19142.
This commit is contained in:
akshatdalton
2021-07-07 20:24:48 +00:00
committed by Tim Abbott
parent 572dbafd06
commit 11c37bca8f
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
frontend_tests/node_tests/composebox_typeahead.js
View File

@@ -1197,18 +1197,22 @@ test("begins_typeahead", ({override}) => {
assert_stream_list(":tada: #foo"); assert_stream_list(":tada: #foo");
assert_typeahead_equals("#foo\n~~~py", lang_list); assert_typeahead_equals("#foo\n~~~py", lang_list);
assert_typeahead_equals("@", false); assert_typeahead_equals("@", all_mentions);
assert_typeahead_equals("@_", false); assert_typeahead_equals("@_", people_only);
assert_typeahead_equals(" @", false); assert_typeahead_equals(" @", all_mentions);
assert_typeahead_equals(" @_", false); assert_typeahead_equals(" @_", people_only);
assert_typeahead_equals("@*", all_mentions);
assert_typeahead_equals("@_*", people_only);
assert_typeahead_equals("@**", all_mentions);
assert_typeahead_equals("@_**", people_only);
assert_typeahead_equals("test @**o", all_mentions); assert_typeahead_equals("test @**o", all_mentions);
assert_typeahead_equals("test @_**o", people_only); assert_typeahead_equals("test @_**o", people_only);
assert_typeahead_equals("test @*o", all_mentions); assert_typeahead_equals("test @*o", all_mentions);
assert_typeahead_equals("test @_*k", people_only); assert_typeahead_equals("test @_*k", people_only);
assert_typeahead_equals("test @*h", all_mentions); assert_typeahead_equals("test @*h", all_mentions);
assert_typeahead_equals("test @_*h", people_only); assert_typeahead_equals("test @_*h", people_only);
assert_typeahead_equals("test @", false); assert_typeahead_equals("test @", all_mentions);
assert_typeahead_equals("test @_", false); assert_typeahead_equals("test @_", people_only);
assert_typeahead_equals("test no@o", false); assert_typeahead_equals("test no@o", false);
assert_typeahead_equals("test no@_k", false); assert_typeahead_equals("test no@_k", false);
assert_typeahead_equals("@ ", false); assert_typeahead_equals("@ ", false);

4
static/js/composebox_typeahead.js
View File

@@ -354,7 +354,7 @@ function filter_mention_name(current_token) {
} else if (current_token.startsWith("*")) { } else if (current_token.startsWith("*")) {
current_token = current_token.slice(1); current_token = current_token.slice(1);
} }
if (current_token.length < 1 || current_token.lastIndexOf("*") !== -1) { if (current_token.lastIndexOf("*") !== -1) {
return false; return false;
} }
@@ -648,7 +648,7 @@ export function get_candidates(query) {
current_token = current_token.slice(1); current_token = current_token.slice(1);
} }
current_token = filter_mention_name(current_token); current_token = filter_mention_name(current_token);
if (!current_token) { if (!current_token && typeof current_token === "boolean") {
this.completing = null; this.completing = null;
return false; return false;
} }