actions: Split out zerver.actions.hotspots.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

zerver/actions/hotspots.py

@@ -0,0 +1,9 @@
+from zerver.lib.hotspots import get_next_hotspots
+from zerver.models import UserHotspot, UserProfile
+from zerver.tornado.django_api import send_event
+
+
+def do_mark_hotspot_as_read(user: UserProfile, hotspot: str) -> None:
+    UserHotspot.objects.get_or_create(user=user, hotspot=hotspot)
+    event = dict(type="hotspots", hotspots=get_next_hotspots(user))
+    send_event(user.realm, event, [user.id])

zerver/lib/actions.py

@@ -98,7 +98,6 @@ from zerver.lib.exceptions import (
 )
 from zerver.lib.export import get_realm_exports_serialized
 from zerver.lib.external_accounts import DEFAULT_EXTERNAL_ACCOUNTS
-from zerver.lib.hotspots import get_next_hotspots
 from zerver.lib.i18n import get_language_name
 from zerver.lib.markdown import MessageRenderingResult, topic_links
 from zerver.lib.markdown import version as markdown_version
@@ -251,7 +250,6 @@ from zerver.models import (
     UserActivityInterval,
     UserGroup,
     UserGroupMembership,
-    UserHotspot,
     UserMessage,
     UserPresence,
     UserProfile,
@@ -7715,12 +7713,6 @@ def do_unmute_user(mute_object: MutedUser) -> None:
     )
 
 
-def do_mark_hotspot_as_read(user: UserProfile, hotspot: str) -> None:
-    UserHotspot.objects.get_or_create(user=user, hotspot=hotspot)
-    event = dict(type="hotspots", hotspots=get_next_hotspots(user))
-    send_event(user.realm, event, [user.id])
-
-
 @transaction.atomic(durable=True)
 def do_add_realm_domain(
     realm: Realm, domain: str, allow_subdomains: bool, *, acting_user: Optional[UserProfile]

zerver/tests/test_events.py

@@ -13,6 +13,7 @@ from unittest import mock
 import orjson
 from django.utils.timezone import now as timezone_now
 
+from zerver.actions.hotspots import do_mark_hotspot_as_read
 from zerver.actions.realm_linkifiers import (
     do_add_linkifier,
     do_remove_linkifier,
@@ -68,7 +69,6 @@ from zerver.lib.actions import (
     do_delete_messages,
     do_invite_users,
     do_make_user_billing_admin,
-    do_mark_hotspot_as_read,
     do_mute_topic,
     do_mute_user,
     do_reactivate_user,

zerver/tests/test_hotspots.py

@@ -1,4 +1,5 @@
-from zerver.lib.actions import do_create_user, do_mark_hotspot_as_read
+from zerver.actions.hotspots import do_mark_hotspot_as_read
+from zerver.lib.actions import do_create_user
 from zerver.lib.hotspots import ALL_HOTSPOTS, INTRO_HOTSPOTS, get_next_hotspots
 from zerver.lib.test_classes import ZulipTestCase
 from zerver.models import UserHotspot, UserProfile, get_realm

zerver/views/hotspots.py

@@ -1,8 +1,8 @@
 from django.http import HttpRequest, HttpResponse
 from django.utils.translation import gettext as _
 
+from zerver.actions.hotspots import do_mark_hotspot_as_read
 from zerver.decorator import human_users_only
-from zerver.lib.actions import do_mark_hotspot_as_read
 from zerver.lib.exceptions import JsonableError
 from zerver.lib.hotspots import ALL_HOTSPOTS
 from zerver.lib.request import REQ, has_request_variables