paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

groups: Remove allow_owners_group field from GroupPermissionSetting.

Browse Source 
As we now allow anonymous groups and settings can be set to any
set of users, there is no benefit in not allowing a setting to
be set to "Owners" group.
This commit is contained in:
Sahil Batra
2024-11-28 15:38:54 +05:30
committed by Tim Abbott
parent a8146916aa
commit 121df45cc4
15 changed files with 44 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/user_groups.ts
View File

@@ -472,22 +472,13 @@ export function check_system_user_group_allowed_for_setting(
group_setting_config: GroupPermissionSetting,
for_new_settings_ui: boolean,
): boolean {
const {
allow_internet_group,
allow_owners_group,
allow_nobody_group,
allow_everyone_group,
allowed_system_groups,
} = group_setting_config;
const {allow_internet_group, allow_nobody_group, allow_everyone_group, allowed_system_groups} =
group_setting_config;
if (!allow_internet_group && group_name === "role:internet") {
return false;
}
if (!allow_owners_group && group_name === "role:owners") {
return false;
}
if ((!allow_nobody_group || for_new_settings_ui) && group_name === "role:nobody") {
return false;
}