paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

groups: Remove allow_owners_group field from GroupPermissionSetting.

Browse Source 
As we now allow anonymous groups and settings can be set to any
set of users, there is no benefit in not allowing a setting to
be set to "Owners" group.
This commit is contained in:
Sahil Batra
2024-11-28 15:38:54 +05:30
committed by Tim Abbott
parent a8146916aa
commit 121df45cc4
15 changed files with 44 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/models/groups.py
View File

@@ -105,7 +105,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_add_members_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=True,
allow_nobody_group=True,
allow_everyone_group=False,
default_group_name="group_creator",
@@ -115,7 +114,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_join_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=True,
allow_nobody_group=True,
allow_everyone_group=False,
default_group_name=SystemGroups.NOBODY,
@@ -125,7 +123,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_leave_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=True,
allow_nobody_group=True,
allow_everyone_group=True,
default_group_name=SystemGroups.EVERYONE,
@@ -135,7 +132,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_manage_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=True,
allow_nobody_group=True,
allow_everyone_group=False,
default_group_name="group_creator",
@@ -145,7 +141,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_mention_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=False,
allow_nobody_group=True,
allow_everyone_group=True,
default_group_name=SystemGroups.EVERYONE,
@@ -155,7 +150,6 @@ class NamedUserGroup(UserGroup): # type: ignore[django-manager-missing] # djang
"can_remove_members_group": GroupPermissionSetting(
require_system_group=False,
allow_internet_group=False,
allow_owners_group=True,
allow_nobody_group=True,
allow_everyone_group=False,
default_group_name=SystemGroups.NOBODY,