paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 19:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

feature_flags: Remove propagate_topic_edits.

Browse Source 
This flag has been set to true since 2013.
This commit is contained in:
Steve Howell
2020-02-27 13:13:35 +00:00
committed by Tim Abbott
parent 7e5c82291f
commit 12ae53f11a
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
static/js/feature_flags.js
View File

@@ -1,6 +1,5 @@
// The features below have all settled into their final states and can // The features below have all settled into their final states and can
// be removed when we get a chance // be removed when we get a chance
exports.propagate_topic_edits = true;
exports.clicking_notification_causes_narrow = true; exports.clicking_notification_causes_narrow = true;
exports.reminders_in_message_action_menu = false; exports.reminders_in_message_action_menu = false;

4
static/js/message_edit.js
View File

@@ -351,7 +351,7 @@ function edit_message(row, raw_content) {
edit_obj.scrolled_by = scroll_by; edit_obj.scrolled_by = scroll_by;
message_viewport.scrollTop(message_viewport.scrollTop() + scroll_by); message_viewport.scrollTop(message_viewport.scrollTop() + scroll_by);
if (feature_flags.propagate_topic_edits && !message.locally_echoed) { if (!message.locally_echoed) {
const original_topic = message.topic; const original_topic = message.topic;
message_edit_topic.keyup(function () { message_edit_topic.keyup(function () {
const new_topic = message_edit_topic.val(); const new_topic = message_edit_topic.val();
@@ -496,10 +496,8 @@ exports.save = function (row, from_topic_edited_only) {
const request = {message_id: message.id}; const request = {message_id: message.id};
if (topic_changed) { if (topic_changed) {
request.topic = new_topic; request.topic = new_topic;
if (feature_flags.propagate_topic_edits) {
const selected_topic_propagation = row.find("select.message_edit_topic_propagate").val() || "change_later"; const selected_topic_propagation = row.find("select.message_edit_topic_propagate").val() || "change_later";
request.propagate_mode = selected_topic_propagation; request.propagate_mode = selected_topic_propagation;
}
changed = true; changed = true;
} }