paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 21:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_validate: Add additional debug info on invalid compose state.

Browse Source 
This will help us debug sentry error when compose send button
is unexpectedly in a disabled state.
This commit is contained in:
Aman Agrawal
2025-03-18 17:13:15 +05:30
committed by Tim Abbott
parent 9af5def4aa
commit 1314aec7e1
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/compose_validate.ts
View File

@@ -12,6 +12,7 @@ import render_stream_wildcard_warning from "../templates/compose_banner/stream_w
import render_wildcard_mention_not_allowed_error from "../templates/compose_banner/wildcard_mention_not_allowed_error.hbs"; import render_wildcard_mention_not_allowed_error from "../templates/compose_banner/wildcard_mention_not_allowed_error.hbs";
import render_compose_limit_indicator from "../templates/compose_limit_indicator.hbs"; import render_compose_limit_indicator from "../templates/compose_limit_indicator.hbs";
import * as blueslip from "./blueslip.ts";
import * as compose_banner from "./compose_banner.ts"; import * as compose_banner from "./compose_banner.ts";
import * as compose_pm_pill from "./compose_pm_pill.ts"; import * as compose_pm_pill from "./compose_pm_pill.ts";
import * as compose_state from "./compose_state.ts"; import * as compose_state from "./compose_state.ts";
@@ -1020,10 +1021,12 @@ export let validate = (scheduling_message: boolean, show_banner = true): boolean
compose_state.get_message_type() !== "private" && compose_state.get_message_type() !== "private" &&
!validate_stream_message(scheduling_message, show_banner) !validate_stream_message(scheduling_message, show_banner)
) { ) {
blueslip.debug("Invalid compose state: Stream message validation failed");
return false; return false;
} }
if (compose_state.get_message_type() === "private" && !validate_private_message(show_banner)) { if (compose_state.get_message_type() === "private" && !validate_private_message(show_banner)) {
blueslip.debug("Invalid compose state: Private message validation failed");
return false; return false;
} }
@@ -1036,6 +1039,7 @@ export let validate = (scheduling_message: boolean, show_banner = true): boolean
$("textarea#compose-textarea").toggleClass("invalid", true); $("textarea#compose-textarea").toggleClass("invalid", true);
$("textarea#compose-textarea").trigger("focus"); $("textarea#compose-textarea").trigger("focus");
} }
blueslip.debug("Invalid compose state: Empty message");
return false; return false;
} else if ($("textarea#compose-textarea").hasClass("invalid")) { } else if ($("textarea#compose-textarea").hasClass("invalid")) {
// Hide the invalid indicator now that it's non-empty. // Hide the invalid indicator now that it's non-empty.
@@ -1051,15 +1055,18 @@ export let validate = (scheduling_message: boolean, show_banner = true): boolean
compose_banner.CLASSNAMES.zephyr_not_running, compose_banner.CLASSNAMES.zephyr_not_running,
$("#compose_banners"), $("#compose_banners"),
); );
blueslip.debug("Invalid compose state: Zephyr mirroring not running");
return false; return false;
} }
// TODO: This doesn't actually show a banner, it triggers a flash // TODO: This doesn't actually show a banner, it triggers a flash
const trigger_flash = show_banner; const trigger_flash = show_banner;
if (!validate_message_length($("#send_message_form"), trigger_flash)) { if (!validate_message_length($("#send_message_form"), trigger_flash)) {
blueslip.debug("Invalid compose state: Message too long");
return false; return false;
} }
if (upload_in_progress) { if (upload_in_progress) {
blueslip.debug("Invalid compose state: Upload in progress");
return false; return false;
} }