paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_profile_fields: Make field_data optional during update.

Browse Source
This commit is contained in:
Shubham Padia
2024-01-20 13:18:26 +07:00
committed by Tim Abbott
parent c6c392bcc7
commit 137776b092
4 changed files with 55 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
zerver/actions/custom_profile_fields.py
View File

@@ -114,11 +114,20 @@ def try_update_realm_custom_profile_field(
field.display_in_profile_summary = display_in_profile_summary
field.required = required
if field.field_type in (CustomProfileField.SELECT, CustomProfileField.EXTERNAL_ACCOUNT):
if field.field_type == CustomProfileField.SELECT:
assert field_data is not None
if field.field_type in (
CustomProfileField.SELECT,
CustomProfileField.EXTERNAL_ACCOUNT,
):
# If field_data is None, field_data is unchanged and there is no need for
# comparing field_data values.
if field_data is not None and field.field_type == CustomProfileField.SELECT:
remove_custom_profile_field_value_if_required(field, field_data)
field.field_data = orjson.dumps(field_data or {}).decode()
# If field.field_data is the default empty string, we will set field_data
# to an empty dict.
if field_data is not None or field.field_data == "":
field.field_data = orjson.dumps(field_data or {}).decode()
field.save()
notify_realm_custom_profile_fields(realm)