paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 08:56:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

push_notification: Use durable=True for the outermost transaction.

Browse Source 
This commit updates the `transaction.atomic` context manager
used to take a lock on Message row in `handle_push_notification`
to use `durable=True` instead of `savepoint=False`. It helps to
avoid introducing an outer transaction by mistake - resulting in
locking row for a longer duration.

Signed-off-by: Prakhar Pratyush <prakhar@zulip.com>
This commit is contained in:
Prakhar Pratyush
2025-10-06 14:44:36 +05:30
committed by Tim Abbott
parent d6ce1c92b7
commit 140e575ddc
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/push_notifications.py
View File

@@ -1639,7 +1639,7 @@ def handle_push_notification(user_profile_id: int, missed_message: dict[str, Any
# BUG: Investigate why it's possible to get here. # BUG: Investigate why it's possible to get here.
return # nocoverage return # nocoverage
with transaction.atomic(savepoint=False): with transaction.atomic(durable=True):
try: try:
(message, user_message) = access_message_and_usermessage( (message, user_message) = access_message_and_usermessage(
user_profile, user_profile,